Skip to content

fix: Allow optional initProcessEnabled when enable_execute_command is true #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

fix: Allow optional initProcessEnabled when enable_execute_command is true #319

merged 1 commit into from
Jul 18, 2025

Conversation

@magreenbaum
Copy link
Member

Description

Reverts to previous logic here: https://github.com/terraform-aws-modules/terraform-aws-ecs/pull/136/files
This allows user to override optional initProcessEnabled as needed.

Motivation and Context

Closes: #311

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

bryantbiggs
bryantbiggs approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs changed the title feat: Allow optional initProcessEnabled when enable_execute_command is true fix: Allow optional initProcessEnabled when enable_execute_command is true Jul 18, 2025
@bryantbiggs bryantbiggs merged commit 99f8edd into terraform-aws-modules:master Jul 18, 2025
12 checks passed
antonbabenko pushed a commit that referenced this pull request Jul 18, 2025
@semantic-release-bot
chore(release): version 6.0.6 [skip ci]
086afd9 
## [6.0.6](v6.0.5...v6.0.6) (2025-07-18)

### Bug Fixes

* Allow optional `initProcessEnabled` when `enable_execute_command` is `true` ([#319](#319)) ([99f8edd](99f8edd))
@antonbabenko
Copy link
Member

This PR is included in version 6.0.6 🎉

@magreenbaum magreenbaum deleted the fitx/init_process_enabled branch July 18, 2025 22:52
@nZac
Copy link

nZac commented Jul 20, 2025

Thank you @antonbabenko and @magreenbaum!

@robertalexa
Copy link

Hey guys, could you double check that this PR actually behaves as expected? I have updated the module at my end and initProcessEnabled changed from true to false in the task definition, despite the enable_execute_command being true. This may be a misunderstanding of how merge works, cause I believe initProcessEnabled has a value of false in .terraform/modules/ecs_service/wrappers/container-definition/main.tf line 34. Either that or I am missing something at my end....

My code:
image

My post-update task:
image

My post-update task definition:
image

My pre-update task definition:
image

Any chance you can shed some light?

@magreenbaum magreenbaum mentioned this pull request Aug 3, 2025
Closed
3 tasks
@magreenbaum
Copy link
Member Author

@robertalexa thanks for mentioning this, I've opened this PR to address that: #330

@bryantbiggs bryantbiggs mentioned this pull request Aug 6, 2025
Merged
3 tasks
@bryantbiggs
Copy link
Member

relates to hashicorp/terraform-provider-aws#17988

@github-actions
Copy link

github-actions bot commented Sep 6, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

initProcessEnabled should be optional for enable_execute_command

5 participants

@magreenbaum @antonbabenko @nZac @robertalexa @bryantbiggs